[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

2011-07-06 Thread jbrosenberg
How about some tests? http://gwt-code-reviews.appspot.com/1454806/diff/5001/dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java File dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java (right): http://gwt-code-reviews.appspot.com/1454806/diff/5001/dev/core/src/com/

[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

2011-06-30 Thread zundel
lgtm http://gwt-code-reviews.appspot.com/1454806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

2011-06-30 Thread cromwellian
http://gwt-code-reviews.appspot.com/1454806/diff/1/dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java File dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java (right): http://gwt-code-reviews.appspot.com/1454806/diff/1/dev/core/src/com/google/gwt/dev/js/JsDuplicate

[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

2011-06-30 Thread cromwellian
http://gwt-code-reviews.appspot.com/1454806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

2011-06-28 Thread zundel
Thanks for the explanation. Just one more thing I'm not clear about... http://gwt-code-reviews.appspot.com/1454806/diff/1/dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java File dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java (right): http://gwt-code-reviews.

[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

2011-06-28 Thread cromwellian
On 2011/06/27 15:09:23, zundel wrote: On 2011/06/08 23:26:58, cromwellian wrote: Can you help me understand what the hoist fucntions are about? Normally, virtual methods are declared inline, e.g. function Foo() {} _ = Foo.prototype = new ... _.myMethod = function myMethod(a,b) { code } f

[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

2011-06-27 Thread zundel
On 2011/06/08 23:26:58, cromwellian wrote: Can you help me understand what the hoist fucntions are about? http://gwt-code-reviews.appspot.com/1454806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors