[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)

2013-02-28 Thread mdempsky
LGTM http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails

[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)

2013-02-27 Thread skybrian
Why protected? Also, shouldn't the unit tests be updated? http://gwt-code-reviews.appspot.com/1891804/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To

[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)

2013-02-27 Thread mdempsky
http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java File user/src/com/google/gwt/animation/client/Animation.java (right): http://gwt-code-reviews.appspot.com/1891804/diff/1/user/src/com/google/gwt/animation/client/Animation.java#newcode203

[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)

2013-02-27 Thread mdempsky
On 2013/02/28 01:45:15, jtam wrote: Switched to Public. Not sure what you would like me to do in terms of unit tests. This is just exposing an internal which should be already tested. I think just adding appropriate asserts for isRunning()'s return value to AnimationTest would be sufficient.

[gwt-contrib] Re: Exposed ability for implmentations of Animation.java to check if the animation is currently running. (issue1891804)

2013-02-27 Thread goktug
http://gwt-code-reviews.appspot.com/1891804/diff/7001/user/src/com/google/gwt/animation/client/Animation.java File user/src/com/google/gwt/animation/client/Animation.java (right):