[gwt-contrib] Re: Faster version of LongLib (issue572801)

2010-06-03 Thread jat
LGTM http://gwt-code-reviews.appspot.com/572801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Faster version of LongLib (issue572801)

2010-06-03 Thread rice
http://gwt-code-reviews.appspot.com/572801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Faster version of LongLib (issue572801)

2010-06-02 Thread rice
http://gwt-code-reviews.appspot.com/572801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Faster version of LongLib (issue572801)

2010-06-02 Thread scottb
http://gwt-code-reviews.appspot.com/572801/diff/9001/10015 File user/super/com/google/gwt/emul/java/lang/Number.java (right): http://gwt-code-reviews.appspot.com/572801/diff/9001/10015#newcode245 user/super/com/google/gwt/emul/java/lang/Number.java:245: private static final int[] maxLengthForRad

[gwt-contrib] Re: Faster version of LongLib (issue572801)

2010-06-01 Thread jat
LGTM, just a few comments. http://gwt-code-reviews.appspot.com/572801/diff/9001/10005 File dev/core/super/com/google/gwt/lang/LongLibBase.java (right): http://gwt-code-reviews.appspot.com/572801/diff/9001/10005#newcode55 dev/core/super/com/google/gwt/lang/LongLibBase.java:55: protected static b

[gwt-contrib] Re: Faster version of LongLib (issue572801)

2010-06-01 Thread rice
http://gwt-code-reviews.appspot.com/572801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors