[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

2010-08-04 Thread rice
http://gwt-code-reviews.appspot.com/710802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

2010-08-02 Thread jlabanca
http://gwt-code-reviews.appspot.com/710802/diff/1/9 File user/src/com/google/gwt/user/cellview/client/CellTable.java (right): http://gwt-code-reviews.appspot.com/710802/diff/1/9#newcode527 user/src/com/google/gwt/user/cellview/client/CellTable.java:527: focusable.focus(); I think we should only

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

2010-08-02 Thread rice
http://gwt-code-reviews.appspot.com/710802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

2010-08-02 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/710802/diff/1013/10009 File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java (right): http://gwt-code-reviews.appspot.com/710802/diff/1013/10009#newcode536 user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java:536: Extra

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

2010-08-02 Thread דניאל רייס
Actually CellTreeNodeView is still work in progress and won't be submitted as part of the current CL. Sorry for the confusion. On Mon, Aug 2, 2010 at 12:14 PM, jlaba...@google.com wrote: LGTM http://gwt-code-reviews.appspot.com/710802/diff/1013/10009 File

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

2010-07-29 Thread rice
http://gwt-code-reviews.appspot.com/710802/diff/1/3 File user/src/com/google/gwt/cell/client/Cell.java (right): http://gwt-code-reviews.appspot.com/710802/diff/1/3#newcode71 user/src/com/google/gwt/cell/client/Cell.java:71: boolean isEditing(Element element, Object key); Good idea. On

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

2010-07-28 Thread jlabanca
Looks good with a few concerns. After we try this out, we should go back and make sure we're covering all of the use cases. http://gwt-code-reviews.appspot.com/710802/diff/1/3 File user/src/com/google/gwt/cell/client/Cell.java (right):