[gwt-contrib] Re: Fix GC handling in hosted mode

2009-09-25 Thread John Tamplin
Committed at r6215. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Fix GC handling in hosted mode

2009-09-25 Thread Amit Manjhi
Yes. On Fri, Sep 25, 2009 at 10:35 AM, John Tamplin wrote: > On Fri, Sep 25, 2009 at 1:22 PM, Amit Manjhi wrote: > >> LGTM. Why use a TreeMap in RemoteObjectTable? > > > I basically kept the same thing that Bob had there before, just moved it > from ThreadLocals to an isolated synchronized clas

[gwt-contrib] Re: Fix GC handling in hosted mode

2009-09-25 Thread John Tamplin
On Fri, Sep 25, 2009 at 1:22 PM, Amit Manjhi wrote: > LGTM. Why use a TreeMap in RemoteObjectTable? I basically kept the same thing that Bob had there before, just moved it from ThreadLocals to an isolated synchronized class. I don't see any reason it needs to be ordered, so I will change it

[gwt-contrib] Re: Fix GC handling in hosted mode

2009-09-25 Thread Amit Manjhi
LGTM. Why use a TreeMap in RemoteObjectTable? On Thu, Sep 24, 2009 at 4:26 PM, wrote: > Reviewers: amitmanjhi, > > Description: > This corrects an issue that was there before and implements it on the > client side of BrowserChannel, as needed by HtmlUnit in hosted mode. > > Please review this a