Hi Kevin, You're right, it is different, but I don't think the actual test goes through a different code path. Closing the entire server socket has the same effect as just closing the output stream. See the docs on getInputStream and getOutputStream here:
http://java.sun.com/javase/6/docs/api/java/net/Socket.html Rajeev On Tue, Mar 23, 2010 at 12:50 PM, <k...@google.com> wrote: > LGTM, but PTAL at my comments. > > > http://gwt-code-reviews.appspot.com/250802/diff/1/2 > File > dev/core/test/com/google/gwt/dev/shell/remoteui/MessageTransportTest.java > (right): > > http://gwt-code-reviews.appspot.com/250802/diff/1/2#newcode310 > > dev/core/test/com/google/gwt/dev/shell/remoteui/MessageTransportTest.java:310: > network.shutdown(); > testExecuteRequestAsyncWithClosedReceiveStreamBeforeResponse is slightly > different from the test above -- it calls > network.getServerSocket().getOutputStream().close() > instead of > network.getServerSocket().close() > Are you sure this test is redundant? > I'd like to see the common code refactored to a private method, if you > think this test is worth to keep. > > http://gwt-code-reviews.appspot.com/250802/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
