[gwt-contrib] Re: Fix for delegate paths when using sub-widgets as editors of the exact same object, i.e. using @P... (issue1650803)

2012-02-24 Thread t . broyer
On 2012/02/24 12:02:56, Dan White wrote: > > I'll close off this review, no need to commit the change. I have terrible manners - thanks for your help! Are you maintaining the editors code now? Not "officially", but having dug in this code for a while I'm indicated to review patches ;-) ht

[gwt-contrib] Re: Fix for delegate paths when using sub-widgets as editors of the exact same object, i.e. using @P... (issue1650803)

2012-02-24 Thread t . broyer
On 2012/02/24 09:46:53, Dan White wrote: Will update when I've investigated further. http://gwt-code-reviews.appspot.com/1650803/diff/1/user/test/com/google/gwt/editor/client/impl/DelegateMapTest.java File user/test/com/google/gwt/editor/client/impl/DelegateMapTest.java (right): http://gwt

[gwt-contrib] Re: Fix for delegate paths when using sub-widgets as editors of the exact same object, i.e. using @P... (issue1650803)

2012-02-23 Thread t . broyer
I don't understand the rationale behind this change. http://gwt-code-reviews.appspot.com/1650803/diff/1/user/test/com/google/gwt/editor/client/impl/DelegateMapTest.java File user/test/com/google/gwt/editor/client/impl/DelegateMapTest.java (right): http://gwt-code-reviews.appspot.com/1650803/dif

[gwt-contrib] Re: Fix for delegate paths when using sub-widgets as editors of the exact same object, i.e. using @P... (issue1650803)

2012-02-23 Thread nchalko
LGTM http://gwt-code-reviews.appspot.com/1650803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors