Good catch on the 10k p tags thing. Turns out there was a missing
check for 'bodyDone' in maybeStartModule().
http://gwt-code-reviews.appspot.com/33808/diff/1/3
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (left):
http://gwt-code-reviews.appspot.com/33808/diff/1/3#oldcode284
LGTM++
A few new spacing issues showed up. It could be tabs.
http://gwt-code-reviews.appspot.com/33808/diff/1005/1007
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):
http://gwt-code-reviews.appspot.com/33808/diff/1005/1007#newcode47
Line 47: // The frame that will
candidate for 1.6.5?
On Thursday, May 14, 2009, knor...@google.com wrote:
LGTM++
A few new spacing issues showed up. It could be tabs.
http://gwt-code-reviews.appspot.com/33808/diff/1005/1007
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):
Kinda scary if you ask me. I *believe* it works everywhere, and have good
evidence of it, but still -- if something turns out to be subtly wrong, we
can patch google3, but 1.6.(N5) would be, uh, unpleasant.
On Thu, May 14, 2009 at 12:38 PM, Bruce Johnson br...@google.com wrote:
candidate for
lgtm - and I confirmed parallel on ff3 on os x.
http://gwt-code-reviews.appspot.com/33808/diff/1/3
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (left):
http://gwt-code-reviews.appspot.com/33808/diff/1/3#oldcode284
Line 284: iframe.id = __MODULE_NAME__;
Why was this here? I
Found one thing:
Expanded the host page w/ 10,000 p tags. Turned on 28.8 throttling and
managed to get Showcase's UI injected about 2/3 of the way down the page
amongst the p tags. I would've expected it to be the last element.
http://gwt-code-reviews.appspot.com/33808
Also forgot to add that I confirmed the parallel script-fetching
behavior using the Charles proxy in throttled mode and a large external
Javascript file.
http://gwt-code-reviews.appspot.com/33808
--~--~-~--~~~---~--~~
