[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

2011-06-15 Thread zundel
http://gwt-code-reviews.appspot.com/1447824/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

2011-06-15 Thread aizatsky
Looks good. Thanks for handling this. http://gwt-code-reviews.appspot.com/1447824/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

2011-06-15 Thread jbrosenberg
LGTM w/some nits it looks like CfgBuild could be made such that individual visit methods are a bit more self-contained. It shouldn't be possible for a visitor to an inner loop to modify the unlabeled break/continue statements of an outer loop, etc. Removing them and replacing them at the end,

[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

2011-06-13 Thread zundel
http://gwt-code-reviews.appspot.com/1447824/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

2011-06-13 Thread zundel
http://gwt-code-reviews.appspot.com/1447824/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

2011-06-13 Thread zundel
On 2011/06/13 18:33:24, zundel wrote: chages vs. http://gwt-code-reviews.appspot.com/1453809/ include just a few unit tests. http://gwt-code-reviews.appspot.com/1447824/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors