http://gwt-code-reviews.appspot.com/550801/diff/1/2
File
dev/core/src/com/google/gwt/dev/shell/remoteui/MessageTransport.java
(right):
http://gwt-code-reviews.appspot.com/550801/diff/1/2#newcode240
dev/core/src/com/google/gwt/dev/shell/remoteui/MessageTransport.java:240:
class FutureTaskExtensio
LGTM, just address the comments below before committing. I'll also take
care of the GPE MessageTransport update.
(if you can create a bug and assign it to me about the error logging and
updating MessageTransport in GPE, that would be great:)
http://gwt-code-reviews.appspot.com/550801/diff/1/2
F
Side note: When these changes to MessageTransport land, we should
update GPE so
that it uses this newer version of MessageTransport as well; it's not
a
requirement, but it's nice to keep them somewhat in sync.
Ah, sure thing. You will handle that?
http://gwt-code-reviews.appspot.com/5508
I like the cleanup you've done here - however, there are a few things
that I'd like you to take a look at before I give the LGTM. Let's go for
one more round on this one; we can discuss this stuff f2f if it's
easier.
Side note: When these changes to MessageTransport land, we should update
GPE so
PING rdayal.
http://gwt-code-reviews.appspot.com/550801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
This is definitely something that Rajeev should look at since I didn't
have much to do with this part of it.
On a relatively superficial look everything looks ok, but it seems like
there should be tests that explicitly cover all the cases of trying to
log branches/messages to a logger before the
