[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-05 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1513803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java File dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java (left): http://gwt-code-reviews.appspot.com/1513803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java#oldc

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread zundel
Please add acleung as a reviewer On 2011/08/05 21:19:37, stephenh wrote: http://gwt-code-reviews.appspot.com/1513803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java File dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java (left): http://gwt-code-reviews.appspot.com/1

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread cromwellian
http://gwt-code-reviews.appspot.com/1513803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java File dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java (right): http://gwt-code-reviews.appspot.com/1513803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java#new

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread stephen . haberman
Did you try this against trunk or GWT 2.3/2.4? I made some changes recently to the way liveness of class literals are calculated that may or may not have an effect relative to this. If you mean the "Roll seed-function optimization forward again" commit [1] (or others before it), yeah, I was ho

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread stephen . haberman
On 2011/08/15 13:53:06, zundel wrote: Please add acleung as a reviewer Done. (The edit issue form didn't recognize just "acleung", so I added "acleung@google".com. Hope that's okay.) http://gwt-code-reviews.appspot.com/1513803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributor

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread stephen . haberman
The thing is, if B is a subtype of A, and B is rescued, then A is also rescued. Yeah, the rub is that B did not get rescued into FragmentB, it just ended up there because it was in the set of FragmentA+FragmentB, but not FragmentA or FragmentB individually, in which case it ends up in whicheve

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-09-06 Thread stephen . haberman
Ping. http://gwt-code-reviews.appspot.com/1513803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2012-04-08 Thread zundel
http://gwt-code-reviews.appspot.com/1513803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2012-04-08 Thread rdayal
Ping. Can we get this review wrapped up? I'd like to push this into GWT 2.5 (or close the issue completely, if not). http://gwt-code-reviews.appspot.com/1513803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2012-05-03 Thread rdayal
On 2012/04/05 19:48:18, zundel wrote: Ping Ping. http://gwt-code-reviews.appspot.com/1513803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread Ray Cromwell
On Mon, Aug 15, 2011 at 9:58 AM, wrote: > If you mean the "Roll seed-function optimization forward again" commit > [1] (or others before it), yeah, I was hoping that would fix it, but it > did not. It surprises me that CFA doesn't take care of this and that it needs to be done as a fix up. One