[gwt-contrib] Re: Formalize default filename extensions for ClientBundle

2009-08-19 Thread kplatfoot
Shouldn't com.google.gwt.resources.ext.DefaultExtensions have been included in this patch? http://gwt-code-reviews.appspot.com/61802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--

[gwt-contrib] Re: Formalize default filename extensions for ClientBundle

2009-08-19 Thread kplatfoot
http://gwt-code-reviews.appspot.com/61802/diff/1011/17 File user/src/com/google/gwt/resources/ext/DefaultExtensions.java (right): http://gwt-code-reviews.appspot.com/61802/diff/1011/17#newcode28 Line 28: * {...@link com.google.gwt.resources.client.ClientBundle.SourceSource} annotation The @link

[gwt-contrib] Re: Formalize default filename extensions for ClientBundle

2009-08-19 Thread rjrjr
This is a nice cleanup, but I have questions about your annotation search http://gwt-code-reviews.appspot.com/61802/diff/1011/18 File user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java (right): http://gwt-code-reviews.appspot.com/61802/diff/1011/18#newcode135 Line 135: public stat

[gwt-contrib] Re: Formalize default filename extensions for ClientBundle

2009-08-19 Thread rjrjr
LGTM w/a couple of javadoc tweaks. http://gwt-code-reviews.appspot.com/61802/diff/28/1039 File dev/core/src/com/google/gwt/core/ext/typeinfo/JClassType.java (right): http://gwt-code-reviews.appspot.com/61802/diff/28/1039#newcode368 Line 368: * which this type is assignable. Annotations present

[gwt-contrib] Re: Formalize default filename extensions for ClientBundle

2009-08-19 Thread bobv
> Is there an appropriate more general home for this? I know I do it all the time. > Could it be an instance method on JClassType? Moved to JClassType.findAnnotationInTypeHierarchy() > For annotations marked @Inherited, would the super-crawl even be necessary? @Inherited doesn't work for superi