[gwt-contrib] Re: Four quick compiler code reviews -- trunk

2009-03-04 Thread Scott Blum
Committed as r4935-4938. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Four quick compiler code reviews -- trunk

2009-03-04 Thread Scott Blum
On Wed, Mar 4, 2009 at 9:58 AM, BobV wrote: > On Tue, Mar 3, 2009 at 2:16 AM, Scott Blum wrote: > > SourceGen: all this really does is make it so that when you click on a > > JsniMethodBody in the debugger, you can see the source. > > Is SourceGenerationVisitor specified to be able to recreate t

[gwt-contrib] Re: Four quick compiler code reviews -- trunk

2009-03-04 Thread BobV
On Tue, Mar 3, 2009 at 2:16 AM, Scott Blum wrote: > SourceGen: all this really does is make it so that when you click on a > JsniMethodBody in the debugger, you can see the source. Is SourceGenerationVisitor specified to be able to recreate the original Java input? Also, why keep the comment br