My last commit caused a new Change-Id which caused a new issue to be created:
https://gwt-review.googlesource.com/1460
Is this correct? Did I something wrong?
Am 14.12.2012 um 15:29 schrieb j...@barop.de:
New version in gerrit: https://gwt-review.googlesource.com/#/c/1440/
You should amend your commit, making sure you keep the Change-Id line, not
make a new commit.
Contrary to, say, GitHub, whose pull requests are branch-based, Gerrit is
commit-based: each commit is reviewed independently, and there are
dependencies between changes. So, to update a review, you
And +1 to everything Matthew already said.
http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/client/RequestImpl.java
File user/src/com/google/gwt/http/client/RequestImpl.java (right):
Thanks for the feedback!
On 2012/12/13 19:36:01, mdempsky wrote:
Thanks for the patch. If you don't mind, could you try uploading the
next
revision to Gerrit insead? See instructions at:
https://groups.google.com/d/msg/google-web-toolkit-contributors/fmHDlsnfdEQ/fc6lvNdxROQJ
If that
Thanks for the feedback.
http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml
File user/src/com/google/gwt/http/HTTP.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml#newcode31
Thanks for the patch. If you don't mind, could you try uploading the
next revision to Gerrit insead? See instructions at:
https://groups.google.com/d/msg/google-web-toolkit-contributors/fmHDlsnfdEQ/fc6lvNdxROQJ
If that proves to be too much work though, you can continue using
Rietveld.
http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml
File user/src/com/google/gwt/http/HTTP.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1875803/diff/1/user/src/com/google/gwt/http/HTTP.gwt.xml#newcode31
