[gwt-contrib] Re: GWTTestCase/JUnit tweak to make mixing TestCase and GWTTestCase easier

2009-06-23 Thread scottb
LGTM with comments. http://gwt-code-reviews.appspot.com/47804/diff/1/3 File user/src/com/google/gwt/junit/client/GWTTestCase.java (right): http://gwt-code-reviews.appspot.com/47804/diff/1/3#newcode52 Line 52: * {...@link UnsupportedOperationException}.Instead, override {...@link #gwtSetUp()}

[gwt-contrib] Re: GWTTestCase/JUnit tweak to make mixing TestCase and GWTTestCase easier

2009-06-23 Thread amitmanjhi
LGTM with one inline comment and one design question Is it better to have a special case handling of null or is it better to introduce a default non-null value for this purpose? http://gwt-code-reviews.appspot.com/47804/diff/1/3 File user/src/com/google/gwt/junit/client/GWTTestCase.java

[gwt-contrib] Re: GWTTestCase/JUnit tweak to make mixing TestCase and GWTTestCase easier

2009-06-23 Thread Bruce Johnson
Thanks, r5617. On Tue, Jun 23, 2009 at 8:23 PM, amitman...@google.com wrote: LGTM with one inline comment and one design question Is it better to have a special case handling of null or is it better to introduce a default non-null value for this purpose?