Patch updated to fix GwtAstBuilderTest.
http://gwt-code-reviews.appspot.com/1449818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Can you briefly describe the reason for this change?
If I understand correctly, the change is to extend handling of compile
time constants to Strings as well as base types?
http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
File
Yes, according to the JLS, Strings are considered compiled time
constants, but we've been doing this wrong up to now. (Not that it
mattered before now.)
http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
File
Okay, much nicer! :D
http://gwt-code-reviews.appspot.com/1449818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM w/a couple questions
http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):
lgtm
http://gwt-code-reviews.appspot.com/1449818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
