[gwt-contrib] Re: Implement ROO-933 and ROO-935. Handle java.lang.{Byte/Short/Character/Integer/Long/BigDecimal/Bi... (issue700802)

2010-07-30 Thread amitmanjhi
LGTM. Since you have already taken care of the merge error, there are only minor nits below. Plus, the comments I sent you earlier. Please submit after these changes. One other thing we discussed was to add a RequestFactoryTestSuite class. If you'd like, you can just add a TODO for now.

[gwt-contrib] Re: Implement ROO-933 and ROO-935. Handle java.lang.{Byte/Short/Character/Integer/Long/BigDecimal/Bi... (issue700802)

2010-07-29 Thread amitmanjhi
I cursorily looked at the patch. It looks good but it seems you forgot to upload the changes to the files in the bikeshed dir. I also had a few minor comments, noted below. Let me know when you update the complete patch. http://gwt-code-reviews.appspot.com/700802/diff/2001/3004 File