[gwt-contrib] Re: Implements a reduced scope ValueStore. It's responsible for posting change events (issue290801)

2010-03-30 Thread rjrjr
Patch updated: On Tue, Mar 30, 2010 at 10:33 AM, wrote: Desk review notes: Add version (Comparable) to valueskey, get it over the wire. Surely we'll need it. Done   No change events from ValueStoreJsonImpl#setValues. They should be a CRUD side effect only. Or maybe not on new during a get,

[gwt-contrib] Re: Implements a reduced scope ValueStore. It's responsible for posting change events (issue290801)

2010-03-30 Thread rjrjr
Desk review notes: Add version (Comparable) to valueskey, get it over the wire. Surely we'll need it. No change events from ValueStoreJsonImpl#setValues. They should be a CRUD side effect only. Or maybe not on new during a get, only on change during a get? Try to make EntityListPresenter not tied