LGTM
http://gwt-code-reviews.appspot.com/1428810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
committed as r10134
http://gwt-code-reviews.appspot.com/1428810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I mean that you should have been able to fix it by replace place1 == place2
with place1.equals(place2).
On Wed, May 4, 2011 at 8:39 AM, jlaba...@google.com wrote:
@rjrjr -
What do you mean?
http://gwt-code-reviews.appspot.com/1428810/
--
Also, this change is a stark reminder that we need to get real about request
caching in RequestFactory. You fundamentally shouldn't be doing this, you
should be able to make the redundant request counting on a lower layer to
send it only if necessary.
Bob, I've lost track -- are there hooks in
On Wed, May 4, 2011 at 9:47 AM, Bob Vawter robertvaw...@google.com wrote:
Bob, I've lost track -- are there hooks in place yet that we could
implement
app specific client side caching in a sample like this?
You can call RequestFactory.getSerializer() with an implementation of
a ProxyStore
On Wed, May 4, 2011 at 12:58 PM, Ray Ryan rj...@google.com wrote:
On Wed, May 4, 2011 at 9:47 AM, Bob Vawter robertvaw...@google.comwrote:
Bob, I've lost track -- are there hooks in place yet that we could
implement
app specific client side caching in a sample like this?
You can call
Something as simple as short circuiting all equivalent
RequestFactory.find(EntityProxyIdP) requests, where equivalent takes into
account the proxy version as well as its id, could be very effective.
On Wed, May 4, 2011 at 10:04 AM, John LaBanca jlaba...@google.com wrote:
On Wed, May 4, 2011 at
