[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

2010-07-02 Thread jlabanca
@rice - Do you mind taking another look at the updated Patch Set? http://gwt-code-reviews.appspot.com/645802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

2010-07-02 Thread jlabanca
committed as r8348 http://gwt-code-reviews.appspot.com/645802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

2010-06-30 Thread rice
LGTM http://gwt-code-reviews.appspot.com/645802/diff/1/2 File user/src/com/google/gwt/user/client/ui/Tree.java (right): http://gwt-code-reviews.appspot.com/645802/diff/1/2#newcode1002 user/src/com/google/gwt/user/client/ui/Tree.java:1002: root = new TreeItem() { Is there a way to avoid

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

2010-06-30 Thread jlabanca
http://gwt-code-reviews.appspot.com/645802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Inserting TreeItems into the logical list in the same spot that they are inserted into the physi... (issue645802)

2010-06-30 Thread jlabanca
Updated based on rice's comments. I merged the root changes into TreeItem. http://gwt-code-reviews.appspot.com/645802/diff/1/2 File user/src/com/google/gwt/user/client/ui/Tree.java (right): http://gwt-code-reviews.appspot.com/645802/diff/1/2#newcode1002