[gwt-contrib] Re: Introduce a flag that explicitly turns coverage on/off (default off). (issue1786805)

2012-07-24 Thread isbadawi
On 2012/07/24 23:13:32, skybrian wrote: http://gwt-code-reviews.appspot.com/1786805/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right):

Re: [gwt-contrib] Re: Introduce a flag that explicitly turns coverage on/off (default off). (issue1786805)

2012-07-24 Thread Ray Cromwell
I don't understand why the dual flags, but I would not make it a proper compiler flag because there are some static clinit inits in compiler classes that need to know whether coverage is enabled when the classes are loaded. On Tue, Jul 24, 2012 at 4:13 PM, skybr...@google.com wrote:

[gwt-contrib] Re: Introduce a flag that explicitly turns coverage on/off (default off). (issue1786805)

2012-07-24 Thread skybrian
On 2012/07/24 23:19:54, cromwellian wrote: I don't understand why the dual flags, but I would not make it a proper compiler flag because there are some static clinit inits in compiler classes that need to know whether coverage is enabled when the classes are loaded. I was thinking it would