[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread rjrjr
http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread rjrjr
Updated ValueListBox with some bug fixes http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread jlabanca
Please add test cases (or a TODO) for ValueListBox and anything else that is reasonably stable. http://gwt-code-reviews.appspot.com/780802/diff/3001/4002 File bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java (right):

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread rjrjr
http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread rjrjr
Ready for re-review http://gwt-code-reviews.appspot.com/780802/diff/3001/4002 File bikeshed/src/com/google/gwt/sample/expenses/gwt/ui/employee/EmployeeEditActivity.java (right): http://gwt-code-reviews.appspot.com/780802/diff/3001/4002#newcode88

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread rjrjr
Also noticed that ValueBoxBase test wasn't running, and wasn't passing. All better now. http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread rjrjr
http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/780802/diff/3001/4026 File user/src/com/google/gwt/user/client/ui/ValueListBox.java (right): http://gwt-code-reviews.appspot.com/780802/diff/3001/4026#newcode35 user/src/com/google/gwt/user/client/ui/ValueListBox.java:35: private final MapInteger, T

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread rjrjr
http://gwt-code-reviews.appspot.com/780802/diff/3001/4026 File user/src/com/google/gwt/user/client/ui/ValueListBox.java (right): http://gwt-code-reviews.appspot.com/780802/diff/3001/4026#newcode35 user/src/com/google/gwt/user/client/ui/ValueListBox.java:35: private final MapInteger, T

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread rjrjr
http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces ValueListBox, and uses it in Scaffold to pick (issue780802)

2010-08-19 Thread rjrjr
No more matching on rendered strings, in it goes... On 2010/08/19 22:52:28, Ray Ryan wrote: http://gwt-code-reviews.appspot.com/780802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors