Reviewers: jlabanca, jat,

http://gwt-code-reviews.appspot.com/112809/diff/1/2
File user/src/com/google/gwt/junit/JUnitMessageQueue.java (right):

http://gwt-code-reviews.appspot.com/112809/diff/1/2#newcode54
Line 54: public String desc;
Actually it can't be, the client's ip can change over time, changing the
desc.

http://gwt-code-reviews.appspot.com/112809/diff/1/9
File
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
(right):

http://gwt-code-reviews.appspot.com/112809/diff/1/9#newcode160
Line 160: Window.Location.getParameter(SESSIONCOOKIE_QUERY_PARAM),
Redoing this logic anyhow.

http://gwt-code-reviews.appspot.com/112809/diff/1/10
File user/test/com/google/gwt/junit/JUnitMessageQueueTest.java (right):

http://gwt-code-reviews.appspot.com/112809/diff/1/10#newcode109
Line 109: queue.reportResults(createClientInfo("client4", "safari"),
"desc3",
thanks, this is getting clobbered anyhow

Description:
Updated implementation to not use cookies. NOTE: this diff is against
the previous trunk revision before my first shot at this.

Please review this at http://gwt-code-reviews.appspot.com/112809

Affected files:
   M user/src/com/google/gwt/junit/JUnitMessageQueue.java
   M user/src/com/google/gwt/junit/JUnitShell.java
   M user/src/com/google/gwt/junit/client/impl/ExceptionWrapper.java
   M user/src/com/google/gwt/junit/client/impl/JUnitHost.java
   M user/src/com/google/gwt/junit/client/impl/JUnitHostAsync.java
   M user/src/com/google/gwt/junit/client/impl/JUnitResult.java
   M user/src/com/google/gwt/junit/server/JUnitHostImpl.java
   M  
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
   M user/test/com/google/gwt/junit/JUnitMessageQueueTest.java


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to