@freeland - this patch also removes RunStyle.init(), which was added as
part of the JUnitShell change but isn't actually needed.
http://gwt-code-reviews.appspot.com/72807
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Does MS1 need this patch? (Hint: no.)
On Wed, Sep 30, 2009 at 11:17 AM, jlaba...@google.com wrote:
@freeland - this patch also removes RunStyle.init(), which was added as
part of the JUnitShell change but isn't actually needed.
http://gwt-code-reviews.appspot.com/72807
LGTM with one questiion.
If user tests are unaffected, feel free to commit.
http://gwt-code-reviews.appspot.com/72807/diff/1/3
File user/test/com/google/gwt/junit/JUnitSuite.java (right):
http://gwt-code-reviews.appspot.com/72807/diff/1/3#newcode35
Line 35: // Must run after a GWTTestCase so
You have to be using a test runner that parallelizes tests. I don't
think that is very common (I've only seen one user affected), but I'd
imagine that must people just use the default that JUnit provides.
http://gwt-code-reviews.appspot.com/72807
On Wed, Sep 30, 2009 at 2:36 PM, Ray Ryan rj...@google.com wrote:
Does MS1 need this patch? (Hint: no.)
It is possible that MS1 would need a similar patch for Swing when running
-notHeadless, but I would be ok shipping it without it.
--
John A. Tamplin
Software Engineer (GWT), Google
http://gwt-code-reviews.appspot.com/72807/diff/1/3
File user/test/com/google/gwt/junit/JUnitSuite.java (right):
http://gwt-code-reviews.appspot.com/72807/diff/1/3#newcode35
Line 35: // Must run after a GWTTestCase so JUnitShell is initialized.
This only affects BatchingStrategyTest because it
