[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-08-04 Thread conroy
http://gwt-code-reviews.appspot.com/728801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-08-04 Thread conroy
also in this CL are cpe1.zip and cpe2.zip which are not showing up on rietveld. some of the diff between patchsets is a result of the moving base. http://gwt-code-reviews.appspot.com/728801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-08-04 Thread scottb
LGTM with nit. http://gwt-code-reviews.appspot.com/728801/diff/7001/8015 File dev/core/test/com/google/gwt/dev/resource/impl/ResourceOracleImplTest.java (right): http://gwt-code-reviews.appspot.com/728801/diff/7001/8015#newcode164

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-08-04 Thread conroy
http://gwt-code-reviews.appspot.com/728801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-08-04 Thread conroy
http://gwt-code-reviews.appspot.com/728801/diff/7001/8015 File dev/core/test/com/google/gwt/dev/resource/impl/ResourceOracleImplTest.java (right): http://gwt-code-reviews.appspot.com/728801/diff/7001/8015#newcode164 dev/core/test/com/google/gwt/dev/resource/impl/ResourceOracleImplTest.java:164:

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-08-04 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/728801/diff/27001/28015 File dev/core/test/com/google/gwt/dev/resource/impl/ResourceOracleImplTest.java (right): http://gwt-code-reviews.appspot.com/728801/diff/27001/28015#newcode152

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-07-29 Thread conroy
(rebase from superdevmode) http://gwt-code-reviews.appspot.com/728801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-07-29 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/728801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Optimize ResourceOracle Refresh by removing some archaic guarantees and some other peephole opti... (issue728801)

2010-07-29 Thread scottb
Nit: http://gwt-code-reviews.appspot.com/728801/diff/1/2 File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/728801/diff/1/2#newcode125 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:125: private final Styles styles = new Styles();; Extra