Code LGTM, just noticed some empty auto-generated Javadoc.
http://gwt-code-reviews.appspot.com/766802/diff/19001/20008
File
user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java
(right):
http://gwt-code-reviews.appspot.com/766802/diff/19001/20008#newcode57
done
http://gwt-code-reviews.appspot.com/766802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Don't go like that, unfortunately. Or change our checkstyle rules to allow
builder-style lines that start with dot. Which I would LGTM in a heart beat.
rjrjr
On Fri, Aug 27, 2010 at 5:56 PM, ncha...@google.com wrote:
http://gwt-code-reviews.appspot.com/766802/diff/1/3
File
http://gwt-code-reviews.appspot.com/766802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thank, I moved pretty much all of the impl stuff, and some for
generated use only Interfaces.
http://gwt-code-reviews.appspot.com/766802/diff/1/2
File
user/src/com/google/gwt/validation/client/AbstractBeanDescriptor.java
(right):
http://gwt-code-reviews.appspot.com/766802/diff/1/2#newcode27
http://gwt-code-reviews.appspot.com/766802/diff/1/3
File
user/src/com/google/gwt/validation/client/AbstractGwtSpecificValidator.java
(right):
http://gwt-code-reviews.appspot.com/766802/diff/1/3#newcode69
user/src/com/google/gwt/validation/client/AbstractGwtSpecificValidator.java:69:
http://gwt-code-reviews.appspot.com/766802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/766802/diff/1/2
File
user/src/com/google/gwt/validation/client/AbstractBeanDescriptor.java
(right):
http://gwt-code-reviews.appspot.com/766802/diff/1/2#newcode27
user/src/com/google/gwt/validation/client/AbstractBeanDescriptor.java:27:
* Abstract
