LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/725801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/725801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/725801/diff/12001/13004
File dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java (right):
http://gwt-code-reviews.appspot.com/725801/diff/12001/13004#newcode26
dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java:26: protected
static ThreadLocal uniqu
http://gwt-code-reviews.appspot.com/725801/diff/12001/13004
File dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java (right):
http://gwt-code-reviews.appspot.com/725801/diff/12001/13004#newcode26
dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java:26: protected
static ThreadLocal uniqu
LGTM
http://gwt-code-reviews.appspot.com/725801/diff/12001/13006
File
dev/core/src/com/google/gwt/dev/shell/rewrite/UseMirroredClasses.java
(right):
http://gwt-code-reviews.appspot.com/725801/diff/12001/13006#newcode43
dev/core/src/com/google/gwt/dev/shell/rewrite/UseMirroredClasses.java:43:
{
Ah, that makes sense. Sorry, I don't understand the logging stuff very
well, so my question was more naive than anything. :)
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/725801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/725801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Fri, Jul 30, 2010 at 4:01 PM, Unnur Gretarsdottir wrote:
> On Fri, Jul 30, 2010 at 3:57 PM, Unnur Gretarsdottir
> wrote:
>> On Fri, Jul 30, 2010 at 3:51 PM, Unnur Gretarsdottir
>> wrote:
>>>
>>>
>>> On Fri, Jul 30, 2010 at 3:44 PM, Scott Blum wrote:
Okay, taking this all together
On Fri, Jul 30, 2010 at 3:57 PM, Unnur Gretarsdottir wrote:
> On Fri, Jul 30, 2010 at 3:51 PM, Unnur Gretarsdottir
> wrote:
>>
>>
>> On Fri, Jul 30, 2010 at 3:44 PM, Scott Blum wrote:
>>>
>>> Okay, taking this all together, I'm wondering if the following approach
>>> works, or if there's a fla
On Fri, Jul 30, 2010 at 3:51 PM, Unnur Gretarsdottir wrote:
>
>
> On Fri, Jul 30, 2010 at 3:44 PM, Scott Blum wrote:
>>
>> Okay, taking this all together, I'm wondering if the following approach
>> works, or if there's a flaw in it:
>> - Rewrite any calls that would utilize or return the default
On Fri, Jul 30, 2010 at 3:44 PM, Scott Blum wrote:
> Okay, taking this all together, I'm wondering if the following approach
> works, or if there's a flaw in it:
>
> - Rewrite any calls that would utilize or return the default LogManager.
> (LogManager.getLogManager(), Logger.getLogger()).
>
> -
Okay, taking this all together, I'm wondering if the following approach
works, or if there's a flaw in it:
- Rewrite any calls that would utilize or return the default LogManager.
(LogManager.getLogManager(), Logger.getLogger()).
- Return your own subclass of LogManager instead, which would serv
On Fri, Jul 30, 2010 at 2:39 PM, wrote:
> All of the dev and GWT stuff LGTM. I don't really understand all the
> nuances of the logging plumbing, though. You might want a second pair
> of eyes, unless you're really confident in that part.
>
> Questions:
>
> 1) Why do you need to prefix the logg
All of the dev and GWT stuff LGTM. I don't really understand all the
nuances of the logging plumbing, though. You might want a second pair
of eyes, unless you're really confident in that part.
Questions:
1) Why do you need to prefix the logger name at all? If we've got our
own LogManager in D
16 matches
Mail list logo
