On Wed, Oct 15, 2008 at 1:39 PM, Lex Spoon <[EMAIL PROTECTED]> wrote:
> Cool! LGTU.
Committed at r3760.
I'm going to follow up to this with a patch to pass in the caller of
makeChild() and makeSynthetic() since findCaller() was removed.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~-
Cool! LGTU.
-Lex
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On Wed, Oct 15, 2008 at 2:47 AM, Katharina Probst <[EMAIL PROTECTED]>wrote:
> I would say yes to the equals and compareTo, but I wouldn't consider the
> hashCode a blocking issue (although it's the simplest fix...).
>
> The equals and compareTo have the potential to create information loss (for
>
Would it be correct to summarize the chief blocking issue as needing
to reconsider the equals / compareTo / hashCode functions on
SourceInfo and Correlation?
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Too
Kathrin and I reviewed this together.
In general, this solves an important use case, so let's move forward
on it aside from minor issues.
The following use cases are the ones we could think of:
- Seeing what amount of output code (and in fact the actual code if you
want) corresponds to what i
On Thu, Oct 2, 2008 at 4:56 PM, Lex Spoon <[EMAIL PROTECTED]> wrote:
> 1. Is there any reason to store all correlates as strings? The
I agree that the final API provided by the Correlation type should
be more structured than just a String, but I don't think that it
should hang on to the AST no
On Thu, Oct 2, 2008 at 4:56 PM, Lex Spoon <[EMAIL PROTECTED]> wrote:
> 2. Attaching a method to its overrider parent seems to mix two
> separate meanings of ancestor. In most of SOYC, the ancestors of a
> node are previous versions of the same node, only before some
> transformation had occurred.
The implementation looks good, and the new feature is very good. I
have two design questions, though:
1. Is there any reason to store all correlates as strings? The
problem with strings is that any code that wants to process the
correlates, as opposed to simply printing them out, will need to p
