[gwt-contrib] Re: RR: UiBinder javadoc, including UiObject, CellPanel

2009-11-24 Thread jlabanca
LGTM Just a couple extra newlines that should be removed before committing. http://gwt-code-reviews.appspot.com/111805/diff/10/1013 File user/src/com/google/gwt/user/client/ui/HasHorizontalAlignment.java (right): http://gwt-code-reviews.appspot.com/111805/diff/10/1013#newcode41 Line 41: * Extra

[gwt-contrib] Re: RR: UiBinder javadoc, including UiObject, CellPanel

2009-11-23 Thread Ray Ryan
Updated based on feedback, and added HasHorizontalAlignment and HasVerticalAlignment -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR: UiBinder javadoc, including UiObject, CellPanel

2009-11-23 Thread rjrjr
http://gwt-code-reviews.appspot.com/111805/diff/1/5 File user/src/com/google/gwt/user/client/ui/CellPanel.java (right): http://gwt-code-reviews.appspot.com/111805/diff/1/5#newcode29 Line 29: * Oh, yes it is. :-) http://gwt-code-reviews.appspot.com/111805 -- http://groups.google.com/group/Googl

[gwt-contrib] Re: RR: UiBinder javadoc, including UiObject, CellPanel

2009-11-23 Thread rjrjr
http://gwt-code-reviews.appspot.com/111805/diff/1/4 File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (left): http://gwt-code-reviews.appspot.com/111805/diff/1/4#oldcode923 Line 923: // automagically, according to http://b/issue?id=1867118 Yes, that's why I deleted it. http://gwt-