Thanks! It's in at r5207. The variable name now has a full complement of e's.
-Lex
On Thu, Apr 9, 2009 at 5:01 PM, Scott Blum wrote:
> LGTM, except for misspelled variable name. :-)
>
> On Thu, Apr 9, 2009 at 1:45 PM, Lex Spoon wrote:
>>
>> On Thu, Apr 9, 2009 at 11:27 AM, Scott Blum wrote
LGTM, except for misspelled variable name. :-)
On Thu, Apr 9, 2009 at 1:45 PM, Lex Spoon wrote:
> On Thu, Apr 9, 2009 at 11:27 AM, Scott Blum wrote:
> > Oh, a concrete reason occurred to me this morning why we'd rather have
> the
> > logic in Precompile.run() that binds using OptionCompilationS
On Thu, Apr 9, 2009 at 11:27 AM, Scott Blum wrote:
> Oh, a concrete reason occurred to me this morning why we'd rather have the
> logic in Precompile.run() that binds using OptionCompilationStateRetained
> with OptionMaxPermsPerCompile:
> You'd actually like to turn off OptionCompilationStateRetai
Oh, a concrete reason occurred to me this morning why we'd rather have the
logic in Precompile.run() that binds using OptionCompilationStateRetained
with OptionMaxPermsPerCompile:
You'd actually like to turn off OptionCompilationStateRetained on the final
pass, I mean, the last set of precompilatio
On Wed, Apr 8, 2009 at 11:17 AM, John Tamplin wrote:
> On Wed, Apr 8, 2009 at 11:00 AM, Lex Spoon wrote:
>>
>> Scott, when you get back, can you review this tiny patch, or propose a
>> different way to solve the problem?
>>
>> The problem is that when precompiles are sharded, it's not actually
>
Yeah, we definitely need to solve this. But it does seem a little weird to
have OptionMaxPermsPerCompile extend OptionCompilationStateRetained, since
the compilation state retained stuff is kind of an implementation detail.
Somehow it seems preferable to me to handle this association in
Precompile
On Wed, Apr 8, 2009 at 11:00 AM, Lex Spoon wrote:
> Scott, when you get back, can you review this tiny patch, or propose a
> different way to solve the problem?
>
> The problem is that when precompiles are sharded, it's not actually
> sound to discard all early compilation state in the middle of
