It still sounds to me like the route Scott suggested and Bob agreed with
would be better, so as to avoid the whole issue of re-lexing the JS during
link.
On Tue, Apr 14, 2009 at 1:19 AM, Vitali Lovich vlov...@gmail.com wrote:
Should've mentioned this in the original post, but probably the
The code LG, one high-level comment about the design. Assuming we're ok
with the design implications, this seems good.
http://gwt-code-reviews.appspot.com/21801/diff/1/2
File
dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
(right):
On Mon, Apr 13, 2009 at 2:40 PM, sco...@google.com wrote:
The code LG, one high-level comment about the design. Assuming we're ok
with the design implications, this seems good.
The never-fail way to do this would be to have JsSourceGeneration
visitor indicate offset values of top-level
On Mon, Apr 13, 2009 at 2:55 PM, Scott Blum sco...@google.com wrote:
Actually, I am going to have to torpedo this (sorry!). It just occurred to
me that while comments are only a hypothetical problem, string literals are
a real, actual problem that could cause problems today. A string literal
If we were playing Mao, I would give you a card penalty for stating the
obvious. :-)
But uh, reliably tracking whether or not you're in a string literal is about
as much fun as writing a JavaScript parser. In fact, it might be *exactly*
as fun, if you know what I mean.
On Mon, Apr 13, 2009 at
On Mon, Apr 13, 2009 at 3:51 PM, Scott Blum sco...@google.com wrote:
If we were playing Mao, I would give you a card penalty for stating the
obvious. :-)
But uh, reliably tracking whether or not you're in a string literal is
about as much fun as writing a JavaScript parser. In fact, it
On Mon, Apr 13, 2009 at 1:53 PM, John Tamplin j...@google.com wrote:
On Mon, Apr 13, 2009 at 3:51 PM, Scott Blum sco...@google.com wrote:
If we were playing Mao, I would give you a card penalty for stating the
obvious. :-)
But uh, reliably tracking whether or not you're in a string literal
On Mon, Apr 13, 2009 at 1:53 PM, John Tamplin j...@google.com wrote:
On Mon, Apr 13, 2009 at 3:51 PM, Scott Blum sco...@google.com wrote:
If we were playing Mao, I would give you a card penalty for stating the
obvious. :-)
But uh, reliably tracking whether or not you're in a string literal
Hey guys,
Rhino http://www.mozilla.org/rhino/ (one of Mozilla's javascript engines)
is written entirely in Java supports JS 1.7 if that helps. I'm sure
there's a parser component in there that can be extracted if the license is
compatible (MPL/GPL).
There's also GromJS
