[gwt-contrib] Re: RR : Initial add of generator for RequestFactoryEditorDriver (issue823801)

2010-09-01 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/823801/diff/2001/3020 File user/src/com/google/gwt/editor/client/LeafValueEditor.java (right): http://gwt-code-reviews.appspot.com/823801/diff/2001/3020#newcode23 user/src/com/google/gwt/editor/client/LeafValueEditor.java:23: public interface LeafValueEd

[gwt-contrib] Re: RR : Initial add of generator for RequestFactoryEditorDriver (issue823801)

2010-09-01 Thread bobv
Updated with feedback. Most of the new code has been moved into the requestfactory package. TakesValue really should be outside of the user.client.ui package. Any objections to moving it into the user.client package? http://gwt-code-reviews.appspot.com/823801/diff/2001/3002 File samples/dynat

[gwt-contrib] Re: RR : Initial add of generator for RequestFactoryEditorDriver (issue823801)

2010-09-01 Thread rjrjr
Should you add the change to make HasText extend TakesValue? http://gwt-code-reviews.appspot.com/823801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Initial add of generator for RequestFactoryEditorDriver (issue823801)

2010-09-01 Thread rjrjr
http://gwt-code-reviews.appspot.com/823801/diff/2001/3002 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java (right): http://gwt-code-reviews.appspot.com/823801/diff/2001/3002#newcode57 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/