LGTM
http://gwt-code-reviews.appspot.com/160801/diff/70001/71009
File dev/core/src/com/google/gwt/dev/CompilePerms.java (right):
http://gwt-code-reviews.appspot.com/160801/diff/70001/71009#newcode354
dev/core/src/com/google/gwt/dev/CompilePerms.java:354:
PropertyPermutations workList =
Ready for another round of reviews.
I rebased patch set 6 to r7776.
http://gwt-code-reviews.appspot.com/160801/diff/16001/17002
File dev/core/src/com/google/gwt/core/ext/linker/SoftPermutation.java
(right):
http://gwt-code-reviews.appspot.com/160801/diff/16001/17002#newcode25
LGTM with nits, but Lex should double-check the CompilePerms change.
http://gwt-code-reviews.appspot.com/160801/diff/16001/17015
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
http://gwt-code-reviews.appspot.com/160801/diff/16001/17015#newcode240
Mostly LG, some comments. Also mostly agree with Lex's comments, too.
I called out a couple in particular that are sort of style questions
where I agree.
http://gwt-code-reviews.appspot.com/160801/diff/16001/17002
File dev/core/src/com/google/gwt/core/ext/linker/SoftPermutation.java
(right):
On Thu, Mar 18, 2010 at 7:38 PM, John Tamplin j...@google.com wrote:
On Thu, Mar 18, 2010 at 7:25 PM, sp...@google.com wrote:
The main issue is that I don't believe that sharded builds will take
full advantage of the collapsing. We need for Precompile to emit the
number of *collapsed*
The module changes look great. Most of the implementation looks great,
though I saw a few places we might be able to simplify it.
The main issue is that I don't believe that sharded builds will take
full advantage of the collapsing. We need for Precompile to emit the
number of *collapsed*
On Thu, Mar 18, 2010 at 7:25 PM, sp...@google.com wrote:
The main issue is that I don't believe that sharded builds will take
full advantage of the collapsing. We need for Precompile to emit the
number of *collapsed* permutations, but it looks like it emits the
number before collapsing.
