Thanks for the review. Subsequent ones should be relatively more
self-contained.
Committed at r3684.
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~--
On Wed, Sep 24, 2008 at 11:53 AM, BobV <[EMAIL PROTECTED]> wrote:
> Changes from previous patch:
> - SourceInfos are now created only via JProgram and JsProgram.
> Descendant collection is now a field in the program types.
> - Optimized getRoots() call in SourceInfo
> - Addressed nits
LGTM. I
On Wed, Sep 24, 2008 at 11:53 AM, BobV <[EMAIL PROTECTED]> wrote:
> SourceInfo is now an abstract class with a protected constructor.
> Each AST package has its own SourceInfo subtype with package-protected
> constructors to ensure that only the relevant program type constructs
> SourceInfo object
Changes from previous patch:
- SourceInfos are now created only via JProgram and JsProgram.
Descendant collection is now a field in the program types.
- Optimized getRoots() call in SourceInfo
- Addressed nits
SourceInfo is now an abstract class with a protected constructor.
Each AST package
This is really cool, Bob! It adds a history to each AST node showing
where it came from. Thus, you can track an individual node backwards
through a long series of
Right now, the histories just hold a parent node and a string
description of what changed. Given how it's laid out, though, it will
