[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)

2010-12-15 Thread jbrosenberg
Do we want to hide this change initially behind a flag (e.g. -DXuseByteCodeToBuildTypeOracle)? http://gwt-code-reviews.appspot.com/1217801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256

[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)

2010-12-15 Thread zundel
Regarding the command line flag: At this point we aren't ready for it, this change doesn't change the logic of building the TypeOracle at all - we've been using byte code generated from JDT for a couple of years now. This change just reorganizes TypeOracleMediator so I can feed it byte code

[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)

2010-12-15 Thread zundel
Added TODO(), renamed unit test to end in string 'Test' so it will be picked up in Ant. http://gwt-code-reviews.appspot.com/1217801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256

[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)

2010-12-15 Thread zundel
http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)

2010-12-15 Thread zundel
http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)

2010-12-15 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/1217801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)

2010-12-15 Thread jbrosenberg
LGTM http://gwt-code-reviews.appspot.com/1217801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java (right): http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256 dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:256: I see now that you were