[gwt-contrib] Re: Remove misleading change record from MethodInliner. (issue934801)

2010-09-29 Thread Eric Ayers
Scott, From what I can tell, is the last reference to JModVisitor.madeChanges(), maybe we should remove that method. On Wed, Sep 29, 2010 at 6:17 PM, sco...@google.com wrote: Reviewers: zundel, Description: The real AST isn't being mutated here, that happens a few lines below. Please

[gwt-contrib] Re: Remove misleading change record from MethodInliner. (issue934801)

2010-09-29 Thread Scott Blum
It is the last reference to the (int) version. There are refs to the no-arg version in my copy. I can definitely remove it. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove misleading change record from MethodInliner. (issue934801)

2010-09-29 Thread zundel
LGTM On 2010/09/29 23:50:45, scottb wrote: It is the last reference to the (int) version. There are refs to the no-arg version in my copy. I can definitely remove it. http://gwt-code-reviews.appspot.com/934801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors