[gwt-contrib] Re: Removes the completely spurious generatedResource directory. (issue289801)

2010-03-30 Thread jat
Mostly LGTM. http://gwt-code-reviews.appspot.com/289801/diff/1/6 File dev/core/src/com/google/gwt/dev/DevModeBase.java (left): http://gwt-code-reviews.appspot.com/289801/diff/1/6#oldcode444 dev/core/src/com/google/gwt/dev/DevModeBase.java:444: File getShellBaseWorkDir(ModuleDef moduleDef);

[gwt-contrib] Re: Removes the completely spurious generatedResource directory. (issue289801)

2010-03-30 Thread scottb
http://gwt-code-reviews.appspot.com/289801/diff/1/6 File dev/core/src/com/google/gwt/dev/DevModeBase.java (left): http://gwt-code-reviews.appspot.com/289801/diff/1/6#oldcode444 dev/core/src/com/google/gwt/dev/DevModeBase.java:444: File getShellBaseWorkDir(ModuleDef moduleDef); Not sure.. this

[gwt-contrib] Re: Removes the completely spurious generatedResource directory. (issue289801)

2010-03-30 Thread bobv
LGTM. http://gwt-code-reviews.appspot.com/289801/diff/1/10 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (right): http://gwt-code-reviews.appspot.com/289801/diff/1/10#newcode240 dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:240: private final