[gwt-contrib] Re: Renamed portHosted to codeServerPort incompatible with GWT 2.0 RC1 eclipse plugin

2009-11-25 Thread Hilbrand
Thanks for the info. I was trying the trunk (R7176), because of the problems with appengine support (gwt.xml not found), which would be fixed in R6996, so I updated and build from trunk. I'll try to continue with R7000, which seems to work for me so far. Hilbrand. On Nov 25, 5:44 pm, John Tamplin

[gwt-contrib] Re: Renamed portHosted to codeServerPort

2009-11-18 Thread mmendez
Thanks guys. http://gwt-code-reviews.appspot.com/103810/diff/1/2 File dev/core/src/com/google/gwt/dev/DevModeBase.java (right): http://gwt-code-reviews.appspot.com/103810/diff/1/2#newcode263 Line 263: private static final String CODE_SERVER_PORT_TAG = "-codeServerPort"; Actually, the name change

[gwt-contrib] Re: Renamed portHosted to codeServerPort

2009-11-18 Thread rdayal
LGTM. http://gwt-code-reviews.appspot.com/103810/diff/1/2 File dev/core/src/com/google/gwt/dev/DevModeBase.java (right): http://gwt-code-reviews.appspot.com/103810/diff/1/2#newcode272 Line 272: return new String[] {CODE_SERVER_PORT_TAG, "9997"}; Could extract a constant for this, since you use i

[gwt-contrib] Re: Renamed portHosted to codeServerPort

2009-11-18 Thread jat
LGTM, might want to ping Bruce about naming http://gwt-code-reviews.appspot.com/103810/diff/1/2 File dev/core/src/com/google/gwt/dev/DevModeBase.java (right): http://gwt-code-reviews.appspot.com/103810/diff/1/2#newcode263 Line 263: private static final String CODE_SERVER_PORT_TAG = "-codeServerP