LGTM. I just realized that I had 2 comments on the FavoritesWidget,
other than the on-phone comments about DeltaValueStore. Just nits.
http://gwt-code-reviews.appspot.com/921801/diff/8001/9005
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/FavoritesWidget.java
(rig
To be clear, all these comments are nits. If you need to submit and
follow up to get to them, that's cool.
On 2010/09/24 21:48:40, rjrjr wrote:
LGTM
As we discussed, putting the new JSO in the master value store feels
skeevey but
should do no harm for this patch. Landing this lets us procee
LGTM
As we discussed, putting the new JSO in the master value store feels
skeevey but should do no harm for this patch. Landing this lets us
proceed.
We have uncovered a pretty serious problem with the api, the fact that
requests are not responsible for their own creates. I'll log a follow up
is
Updated with the following tests and the fixes to make them work:
- setter collection behavior
- dummy creates involving collections.
Also did some code cleanup in the files I touched this morning. The
warning spam was making it difficult to see newly-introduced problems.
http://gwt-code-r
Partial review. I looked at the DeltaValueStore, Proxy* and
AbstractRequest code in user and it looks good except one thing -- I
don't think the commit method should be putting values in the
deltaValueStore. We don't know for sure, if all fields have been
persisted. And the entity value will be re
