[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-28 Thread rjrjr
Thanks for looking, guys. Submitting these fixes. http://gwt-code-reviews.appspot.com/389802/diff/11/4001 File /bikeshed/src/com/google/gwt/app/place/Activity.java (right): http://gwt-code-reviews.appspot.com/389802/diff/11/4001#newcode49 /bikeshed/src/com/google/gwt/app/place/Activity.java:49:

[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-28 Thread amitmanjhi
Sorry for the delay in review. LGTM. Few nits below. http://gwt-code-reviews.appspot.com/389802/diff/11/4001 File /bikeshed/src/com/google/gwt/app/place/Activity.java (right): http://gwt-code-reviews.appspot.com/389802/diff/11/4001#newcode50 /bikeshed/src/com/google/gwt/app/place/Activity.java

[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-28 Thread rjrjr
TBR'd this to get it in before Joel re-orgs http://gwt-code-reviews.appspot.com/389802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-28 Thread rjrjr
ping http://gwt-code-reviews.appspot.com/389802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-27 Thread Amit Manjhi
Sure, I can take a look at it tomorrow morning. On Tue, Apr 27, 2010 at 9:11 PM, wrote: > Ray, any chance of you getting to this tonight? If not, Amit, maybe you > can take it in the morning? > > > http://gwt-code-reviews.appspot.com/389802/show > -- http://groups.google.com/group/Google-Web-T

[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-27 Thread rjrjr
http://gwt-code-reviews.appspot.com/389802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Simplifies ActivityManager a bit, and adds a JRE unit test -- not (issue389802)

2010-04-27 Thread rjrjr
Ray, any chance of you getting to this tonight? If not, Amit, maybe you can take it in the morning? http://gwt-code-reviews.appspot.com/389802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors