[gwt-contrib] Re: Small code review, HasValue javadoc

2008-12-02 Thread Ray Ryan
Submitted r4234 On Tue, Dec 2, 2008 at 3:05 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: > Seeing as we don't actually throw any of those yet, I'd like to stay > ambiguous on that front. > rjrjr > > > On Tue, Dec 2, 2008 at 2:58 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > >> Should we say that Ille

[gwt-contrib] Re: Small code review, HasValue javadoc

2008-12-02 Thread Ray Ryan
Seeing as we don't actually throw any of those yet, I'd like to stay ambiguous on that front. rjrjr On Tue, Dec 2, 2008 at 2:58 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > Should we say that IllegalArgumentExceptions should be preferred for > invalid input? > Other then that, LGTM. > > > On

[gwt-contrib] Re: Small code review, HasValue javadoc

2008-12-02 Thread Emily Crutcher
Should we say that IllegalArgumentExceptions should be preferred for invalid input? Other then that, LGTM. On Tue, Dec 2, 2008 at 5:39 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: > Per our earlier conversation, softening the requirements on HasValue. > Intended for submission to releases/1.6 > rjrjr