[gwt-contrib] Re: Small generator testing framework (issue1424805)

2011-04-20 Thread rjrjr
LGTM This is sweet. http://gwt-code-reviews.appspot.com/1424805/diff/1/dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java File dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java (right): http://gwt-code-reviews.appspot.com/1424805/diff/1/dev/core

[gwt-contrib] Re: Small generator testing framework (issue1424805)

2011-04-19 Thread Scott Blum
Yeah, they're in an impl package. On Tue, Apr 19, 2011 at 11:12 AM, wrote: > I think the idea here is that no one (outside the existing GWT tests) > should reference the *Resource classes directly - that's why we have the > new interface Source. This way, you should be able to refactor the > *Re

[gwt-contrib] Re: Small generator testing framework (issue1424805)

2011-04-19 Thread zundel
LGTM2 http://gwt-code-reviews.appspot.com/1424805/diff/1/dev/core/src/com/google/gwt/dev/javac/testing/impl/MockResource.java File dev/core/src/com/google/gwt/dev/javac/testing/impl/MockResource.java (right): http://gwt-code-reviews.appspot.com/1424805/diff/1/dev/core/src/com/google/gwt/dev/jav