LGTM with nits.
http://gwt-code-reviews.appspot.com/64805/diff/1015/1018
File dev/linux/src/com/google/gwt/dev/BootStrapPlatform.java (right):
http://gwt-code-reviews.appspot.com/64805/diff/1015/1018#newcode41
Line 41: System.err.println(You must use a 32-bit runtime to use GWT
Hosted Mode on
On 2009/09/03 19:07:53, knorton wrote:
Ray,
Can you confirm that this patch fixes the Snow Leopard issue. It's the
same
patch as before with the typo fixed and the error message slightly
expanded.
Since we have the 32-bit issue on other platforms, should we do this in
common code instead?
On 2009/09/03 19:07:53, knorton wrote:
Ray,
Can you confirm that this patch fixes the Snow Leopard issue. It's the
same
patch as before with the typo fixed and the error message slightly
expanded.
Works on Snow Leopard with IntelliJ as launcher against GWT 2.0 trunk.
LGTM.
In the rare cases it fails, the user will just get what they get by
default now. Seems like we should go ahead and do it for all the
platforms. I'll add the checking to HostedModeBase, but have it call
back into BootStrapPlatform for the error message so we can keep the OS
X specific hints.
@Ray: To clarify, you need to add -d32 to the launch config though, right?
On Thu, Sep 3, 2009 at 3:22 PM, cromwell...@gmail.com wrote:
On 2009/09/03 19:07:53, knorton wrote:
Ray,
Can you confirm that this patch fixes the Snow Leopard issue. It's the
same
patch as before with the typo
Sure, does sun.arch.data.model work everywhere?
/kel
On 2009/09/03 19:17:16, jat wrote:
On 2009/09/03 19:07:53, knorton wrote:
Ray,
Can you confirm that this patch fixes the Snow Leopard issue. It's
the same
patch as before with the typo fixed and the error message slightly
expanded.
I can't say it'll work everywhere, but it's in the official Sun Hotspot
FAQ:
http://www.j2ee.me/docs/hotspot/HotSpotFAQ.html#64bit_detection
On 2009/09/03 19:21:06, knorton wrote:
Sure, does sun.arch.data.model work everywhere?
/kel
On 2009/09/03 19:17:16, jat wrote:
On 2009/09/03
If you are on IntelliJ IDEA, I'm not sure about Eclipse. OSX has this app
called Java Preferences.app that changes the system /usr/bin/java so that
it points to which VM you want, so when you type java -version from the
command line, you'll get the appropriate VM. That is, if you select 32-bit,
it
Doing it all platforms style.
I also confirmed that this does the right thing on Leopard when you run
both the 1.5 and 1.6 vms.
http://gwt-code-reviews.appspot.com/64805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
