LGTM
Really nice, just one nit below.
http://gwt-code-reviews.appspot.com/993801/diff/7001/8001
File user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
(right):
http://gwt-code-reviews.appspot.com/993801/diff/7001/8001#newcode185
user/src/com/google/gwt/uibinder/rebind/model/Ow
You better sit down for this: reviewing now.
On Mon, Nov 1, 2010 at 8:51 AM, wrote:
> ping.
>
> On 2010/10/14 19:46:03, fabiomfv wrote:
>
>> +1.
>>
>
> there is the possibility of choosing incorrectly since we are not able
>>
> to
>
>> look at the parameter type 'passed in' (proposed fix 2 woul
ping.
On 2010/10/14 19:46:03, fabiomfv wrote:
+1.
there is the possibility of choosing incorrectly since we are not able
to
look at the parameter type 'passed in' (proposed fix 2 would work on
that
basis, but is a higher impact change). As Ray mentioned, the safe
workaround
is to provid
+1.
there is the possibility of choosing incorrectly since we are not able to
look at the parameter type 'passed in' (proposed fix 2 would work on that
basis, but is a higher impact change). As Ray mentioned, the safe workaround
is to provide a different name.
On Thu, Oct 14, 2010 at 3:22 PM, Ray
By providing a setter with a different name, I guess. An alternative would
be to provide a new annotation, but that still presumes that they control
the widget source, not much of a win.
On Thu, Oct 14, 2010 at 12:11 PM, wrote:
> How does the user override the heuristic if it chooses incorrectly
How does the user override the heuristic if it chooses incorrectly?
http://gwt-code-reviews.appspot.com/993801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/993801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/993801/diff/1/3
File
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java
(right):
http://gwt-code-reviews.appspot.com/993801/diff/1/3#newcode146
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java:146:
public void testCh
http://gwt-code-reviews.appspot.com/993801/diff/1/2
File user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
(right):
http://gwt-code-reviews.appspot.com/993801/diff/1/2#newcode46
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:46:
private static HashMap typeRan
That's a nice approach.
http://gwt-code-reviews.appspot.com/993801/diff/1/2
File user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
(right):
http://gwt-code-reviews.appspot.com/993801/diff/1/2#newcode46
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:46:
priva
10 matches
Mail list logo
