[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-20 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/diff/4007/dev/core/src/com/google/gwt/dev/ArchivePreloader.java File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/4007/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode59 de

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-20 Thread tobyr
LGTM http://gwt-code-reviews.appspot.com/1461801/diff/4007/dev/core/src/com/google/gwt/dev/ArchivePreloader.java File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/4007/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcod

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-17 Thread stephen . haberman
FYI this archiving feature won't be on by default in the GWT 2.4 release. Cool, I was wondering about that. I'll likely stay with trunk. http://gwt-code-reviews.appspot.com/1461801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-17 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/diff/4005/dev/core/src/com/google/gwt/dev/ArchivePreloader.java File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/4005/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode65 de

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-17 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-17 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1461801/diff/4005/dev/core/src/com/google/gwt/dev/ArchivePreloader.java File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/4005/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode65 de

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-17 Thread zundel
I moved a method to get the timestamp from a resource referenced by a URL from AbstractClientBundleGenerator I wanted to use in CompileModule and moved it. http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java File dev/core/src/com/google/gwt

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-17 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-17 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-17 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-16 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode49 de

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-16 Thread tobyr
LGTM http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcod

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-16 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode217 dev/core/src/com

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-16 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-16 Thread jbrosenberg
LGTM w/a couple comments http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/CompileModule.java#n

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-16 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/ArchivePreloader.java File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode34 dev/core

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

2011-06-16 Thread zundel
http://gwt-code-reviews.appspot.com/1461801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors