Hey Scott, not sure, did you mean to link to a different issue for the
backend issue? The link above points back to this fix for the
front-end issue.
http://gwt-code-reviews.appspot.com/1470803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Sorry, the back-end issue is here:
http://gwt-code-reviews.appspot.com/1469804/
http://gwt-code-reviews.appspot.com/1470803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
So, the tests in the back-end issue are valid, but the GwtAstBuilder patch
is superceded. Could you roll the tests into issue 1470803?
On Wed, Jul 6, 2011 at 10:54 AM, sco...@google.com wrote:
Sorry, the back-end issue is here:
On Wed, Jul 6, 2011 at 12:07 PM, Eric Ayers zun...@google.com wrote:
So, the tests in the back-end issue are valid, but the GwtAstBuilder patch
is superceded. Could you roll the tests into issue 1470803?
Lemme clarify.
The tests in the back-end are valid tests, which fail both with
http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java
File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java
(right):
http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java
File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java
(right):
http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java
File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1470803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1470803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
