[gwt-contrib] Re: Update the mac xpcom plugin for Gecko 2.0 (FF4). This is a platform switch for (issue1311802)

2011-01-24 Thread conroy
http://gwt-code-reviews.appspot.com/1311802/diff/1/2 File plugins/config.mk (right): http://gwt-code-reviews.appspot.com/1311802/diff/1/2#newcode85 plugins/config.mk:85: ALLARCHCFLAGS=-arch i386 -arch ppc -arch x86_64 On 2011/01/24 02:47:49, jat wrote: So we will build with all 3 architectures?

[gwt-contrib] Re: Update the mac xpcom plugin for Gecko 2.0 (FF4). This is a platform switch for (issue1311802)

2011-01-24 Thread fabiomfv
LGTM http://gwt-code-reviews.appspot.com/1311802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update the mac xpcom plugin for Gecko 2.0 (FF4). This is a platform switch for (issue1311802)

2011-01-23 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1311802/diff/1/2 File plugins/config.mk (right): http://gwt-code-reviews.appspot.com/1311802/diff/1/2#newcode85 plugins/config.mk:85: ALLARCHCFLAGS=-arch i386 -arch ppc -arch x86_64 So we will build with all 3 architectures? I thought PPC was being phas

[gwt-contrib] Re: Update the mac xpcom plugin for Gecko 2.0 (FF4). This is a platform switch for (issue1311802)

2011-01-20 Thread conroy
http://gwt-code-reviews.appspot.com/1311802/diff/1/2 File plugins/config.mk (left): http://gwt-code-reviews.appspot.com/1311802/diff/1/2#oldcode75 plugins/config.mk:75: OMARCH=i386 OMARCH wasn't being used anywhere. http://gwt-code-reviews.appspot.com/1311802/diff/1/3 File plugins/xpcom/Makefil