Consistency is good, but this patch breaks a different consistency!
Specifically, the symbolMaps files count permutations from 0. So
permutation 3 in the compile report would be permutation 2 in the
symbolMaps files. I think that consistency is more important than
that the permutation counting
Hi Lex,
you make a good point. There are a couple of counter-arguments, however:
the logging output already uses 1-based counting, and for end users 1-based
counting is probably more intuitive.
Are permutation IDs used in any other artifacts produced by the compiler
(other than symbol maps)
Strawman proposal: how about we internally continue to count permutations
from 0; but any time we produce a user facing message, we add 1 to make it
1-based instead?
The only real reason for suggesting this is-- I think it already works that
way in 90% of the cases. So maybe we just have to
On Fri, Nov 20, 2009 at 11:45 AM, Scott Blum sco...@google.com wrote:
Strawman proposal: how about we internally continue to count permutations
from 0; but any time we produce a user facing message, we add 1 to make it
1-based instead?
This already happens when it comes to compiler logging
After Kathrin and I talked this over, it's become clear that we simply don't
have time to do 1-based counting, correctly, everywhere. Importantly, there
is symbolMaps code in google3 that absolutely depends on 0-based counting.
Looking at the whole situation, I think the wisest course of action
