I'm looking at it right now. On Wed, Feb 18, 2009 at 1:09 PM, Emily Crutcher <e...@google.com> wrote:
> Joel, > > Should I redirect this review to John? As I know you are very > busy, so he may be a better person to review. If you could make the call on > whether this should go into 1.6 or trunk, that would be appreciated though > :-) > > Cheers, > > Emily > > > > On Thu, Feb 12, 2009 at 2:45 PM, <e...@google.com> wrote: > >> Reviewers: jgw, >> >> Description: >> This patch included the implementation of SuggestBox.wrap, correct >> handling of composites wrapping root elements and a better error message >> if a panel tries to add a root widget. >> >> Please review this at http://gwt-code-reviews.appspot.com/2806 >> >> Affected files: >> user/src/com/google/gwt/user/client/ui/Composite.java >> user/src/com/google/gwt/user/client/ui/RootPanel.java >> user/src/com/google/gwt/user/client/ui/SuggestBox.java >> user/src/com/google/gwt/user/client/ui/Widget.java >> user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java >> >> >> > > > -- > "There are only 10 types of people in the world: Those who understand > binary, and those who don't" > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
