[gwt-contrib] Re: code review requested for 1.5, issues 2836, 2894, 2911 - various I18NSync issues

2008-10-14 Thread Alex Rudnick
Alright, taking a look! The code looks good (one typographical nit), but I'm pretty sure you should change the comments in the tests that reference local files on your machine. Also, all the test files should have copyright notices (don't they?), but it looks like you took some of them out. Let

[gwt-contrib] Re: code review requested for 1.5, issues 2836, 2894, 2911 - various I18NSync issues

2008-10-14 Thread John Tamplin
On Tue, Oct 14, 2008 at 3:41 PM, Alex Rudnick [EMAIL PROTECTED] wrote: The code looks good (one typographical nit), but I'm pretty sure you should change the comments in the tests that reference local files on your machine. Also, all the test files should have copyright notices (don't they?),